Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump coreos-assembler to Fedora 39 #45710

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Bump coreos-assembler to Fedora 39 #45710

merged 1 commit into from
Nov 15, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 15, 2023 •
edited
Loading

Matches coreos/coreos-assembler#3653.

While we're here, use the Quay.io image instead since that's the future.

@jlebon jlebon mentioned this pull request Nov 15, 2023
Merged
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@mike-nguyen
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@jlebon
Bump coreos-assembler to Fedora 39
036f9e1 
Matches coreos/coreos-assembler#3653.

While we're here, use the Quay.io image instead since that's the future.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@jlebon
Copy link
Member Author

jlebon commented Nov 15, 2023

/pj-rehearse ack

We'll test this in coreos/coreos-assembler#3653.

@openshift-ci-robot openshift-ci-robot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jlebon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-coreos-coreos-assembler-main-images coreos/coreos-assembler presubmit Ci-operator config changed
pull-ci-coreos-coreos-assembler-main-rhcos coreos/coreos-assembler presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jlebon
Copy link
Member Author

jlebon commented Nov 15, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 15, 2023
@dustymabe
Copy link
Member

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 3986f28 into openshift:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe left review comments

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

@prestist prestist Awaiting requested review from prestist

Assignees

@dustymabe dustymabe

@mike-nguyen mike-nguyen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlebon @mike-nguyen @openshift-ci-robot @dustymabe